Do not change preferences for magento default types

ihor-sviziev commented 9 months ago

Description (*)

I noticed that meta extension has adding type preferences for some magento-core classes / interfaces, which are declared in Magento itself. And I don't see the reasoning behind it. This might cause some conflicts with modules that replaces type to their own.

In magento core it's already declared in https://github.com/magento/magento2/blob/2.4/app/etc/di.xml#L124 and in https://github.com/magento/magento2/blob/2.4/app/code/Magento/Backend/etc/di.xml#L9 (2nd one suppose to be removed)

Story

Bug

Task

Fixed Issues (if relevant)

magento-commerce/facebook-for-magento2#: Issue title

Manual testing scenarios (*)

...
...

Questions or comments

Checklist

[ ] Pull request has a meaningful description of its purpose
[ ] All commits are accompanied by meaningful commit messages
[ ] All new or changed code is covered with unit/integration tests (if applicable)
[ ] All automated tests passed successfully (all builds are green)

ihor-sviziev commented 8 months ago

@zlik pls review

zlik commented 8 months ago

Merged in private repo, will release in 1.2.2. Thanks, @ihor-sviziev!

magento / meta-for-magento2

Do not change preferences for magento default types #32