magento / meta-for-magento2

33 stars 19 forks source link

Multiple files need changing to prevent errors with databases with prefixes #53

Closed likearocket closed 1 month ago

likearocket commented 4 months ago

Preconditions (*)

  1. Installing/upgrading extension

Steps to reproduce (*)

  1. Install or upgrade extension

Expected result (*)

  1. Installs / runs without errors

Actual result (*)

  1. Installs but generates errors where database tables cannot be found as extension does not factor in some Magento installations have database prefixes.

This is an ongoing issue going back several months. It is unacceptable that with every new version multiple files have to be edited to prevent error messages appearing in SSH window, and now with module 1.2.6 in the Magento Admin as well, caused by the latest version relating to notification issues.

So far, these are files in the extension that have to have a prefix added to the tables to prevent error messages:

Lines 107 and 113 In Files:

vendor/meta/module-business-extension/Setup/Patch/Data/DeleteLegacyData.php

Lines 33, 210 and 211 In File:

vendor/meta/module-catalog/Model/ResourceModel/FacebookCatalogUpdate.php

Line 13 In File:

vendor/meta/module-catalog/Setup/Patch/Data/AddCatalogSwitch.php

Line 28 In File:

vendor/meta/module-business-extension/Model/ResourceModel/MetaIssueNotification.php