magento / meta-for-magento2

33 stars 19 forks source link

get parent url if is available. #58

Open Bashev opened 3 months ago

Bashev commented 3 months ago

Description (*)

When we have configurable products with simples which are not visible individually we must get parent product url to push proper link to all children. This is correctly defined in ProductRepository https://github.com/magento/meta-for-magento2/blob/9b12569141be385d6e264eb4c456d1d936745f4e/app/code/Meta/Catalog/Model/ProductRepository.php#L94 but on the next line we make all products visible... https://github.com/magento/meta-for-magento2/blob/9b12569141be385d6e264eb4c456d1d936745f4e/app/code/Meta/Catalog/Model/ProductRepository.php#L95 then validation in https://github.com/magento/meta-for-magento2/blob/9b12569141be385d6e264eb4c456d1d936745f4e/app/code/Meta/Catalog/Model/Product/Feed/Builder.php#L252 never will be true and "non visible" product will be returned in all cases.

Fixed Issues (if relevant)

  1. Possible fixes: magento/meta-for-magento2#48

Checklist