magento / meta-for-magento2

33 stars 19 forks source link

Fix for issues in #72 #73

Open snoop0x7b opened 3 weeks ago

snoop0x7b commented 3 weeks ago

Description (*)

This PR fixes the issues outlined in Issue #72. It fixes the query-in-a-loop anti-pattern, the assumption that all items in a quote will be in a category (Which can cause a SQL error), the logic error where the category name array is overwritten for each item in the loop.

Bug

Fixed Issues (if relevant)

  1. magento-commerce/facebook-for-magento2#<72>: Potential errors and performance issues in Tracker/InitiateCheckout

Manual testing scenarios (*)

  1. Create an item that has no categories, add it to the cart and check out. No error should occur.

Checklist