magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.07k stars 684 forks source link

[bug]: venia logo does not load on storefront for upward-php. #1622

Closed dpatil-magento closed 5 years ago

dpatil-magento commented 5 years ago

Describe the bug venia logo does not load on storefront for upward-php.

To Reproduce

  1. Deploy pwa on cloud starter
  2. Access storefront

Expected behavior Storefront should load with all images.

Actual Venia logo does not load.

Screenshots

image
sirugh commented 5 years ago

How do I repro? Do you have a link?

cherdman commented 5 years ago

How do I repro? Do you have a link?

https://develop.pwa-venia.com/ https://magento.pwa-venia.com/

sirugh commented 5 years ago

@cherdman I'm not seeing it happen on either of those.

dpatil-magento commented 5 years ago

@sirugh @cherdman Above two runs on upward-js so you dont see issue there. If we deploy current develop branch on cloud starter then we can see the issue. Let me know if you need cloud starter deployed instance.

zetlen commented 5 years ago

@dpatil-magento and I have been working on this since yesterday, though I've been on the road so I've been slower than usual. I have a branch zetlen/inline-logo-svg which should fix this issue, but I haven't opened it as a pull request yet.

This issue only appears with UPWARD-PHP on Cloud Pro, and I can't replicate those conditions locally. Therefore @dpatil-magento has to confirm that a pushed change is actually fixing the issue. So far:

@dpatil-magento It's ready for you to review, and then if it fixes the issue we can open it as a PR, take a little code review, and do a full end-to-end test run.