magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.06k stars 682 forks source link

[feature request]: Custom Option not showing on PDP page of PWA #2025

Closed ankitpatel2931 closed 3 years ago

ankitpatel2931 commented 4 years ago

Describe the bug Product's custom option showing fine on magento pdp page but now showing on pwa pdp page

To reproduce Steps to reproduce the behavior:

  1. Go to PDP page on PWA. In my case https://magento-venia-concept-wxtj9.local.pwadev:9367/strive-shoulder-pack.html Please refer Magento 2 front-end https://drive.google.com/file/d/1ZD1ODjOTMzUAEgFDPORTqKIoSy19niKM/view?usp=sharing Screenshot from 2019-12-12 12-58-44 Please refer Magento 2 PWA front-end https://drive.google.com/file/d/1kxWd2JzG53VSt0lsZiZWAsUof_k1sEsY/view?usp=sharing Screenshot from 2019-12-12 12-57-53 Add to cart from Magento 2 PWA PDP page gives me error like https://drive.google.com/file/d/13fnMSWfC3xVLhJUMmRJq4610IU9Jnjzf/view?usp=sharing Screenshot from 2019-12-12 13-03-03 The reason is Custom Option is required option. It's not showing on PWA front-end. So, customer can't add value in text box and add to cart product.

Expected behavior Custom Option should work same like Magento 2 front-end.

Please complete the following device information:

sirugh commented 4 years ago

This isn't a bug, it's just not a feature we included. Also worth mentioning for whomever works on this is that we have since merged the add/update actions from REST to GraphQL which means the error may differ if you attempt to add an item without required customization options.

cc @awilcoxa for prioritization

ankitpatel2931 commented 4 years ago

Hi @sirugh ,

Thanks for consider this as new feature request. May I know tentative time for this feature?

Thanks.

awilcoxa commented 4 years ago

Hi @ankitpatel2931 we're currently planning to address support for additional product types and product fields later in the year (likely Q2/Q3). If you'd like to contribute to this feature or take it on now we would welcome your help and can follow up further.

ankitpatel2931 commented 4 years ago

Yeah. I am interested. How can I help you?

On Tue, Jan 21, 2020 at 9:52 PM Andrew Wilcox notifications@github.com wrote:

Hi @ankitpatel2931 https://github.com/ankitpatel2931 we're currently planning to address support for additional product types and product fields later in the year (likely Q2/Q3). If you'd like to contribute to this feature or take it on now we would welcome your help and can follow up further.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/magento/pwa-studio/issues/2025?email_source=notifications&email_token=AKVMGYN7M6C3BCYMPACRNMLQ64ONJA5CNFSM4JZ2IEV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJQKVSY#issuecomment-576760523, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKVMGYJYBW6VCAUY4DQHSMLQ64ONJANCNFSM4JZ2IEVQ .

--

Ankit Jasani Magento 2 Certified Developer +91 908-181-2804 live:c7add3fb77e06f28 ankitpatel2931@gmail.com

awilcoxa commented 4 years ago

We're still in design/research phase for the additional product type support. Once completed we'll be able to move this forward.

nadeefit6 commented 4 years ago

Is there any update for this issue? How can we use Custom Options in pwa-studio?

irajneeshgupta commented 4 years ago

@awilcoxa

Let us know if any updates on this feature request.

Thanks.

larsroettig commented 3 years ago

@davemacaulay i think there is a design missing we should do ux research first

Frodigo commented 3 years ago

@larsroettig, in my opinion, UX research is not necessary here. We can use global venia styles & elements and do this functionality similar as in Magento Luma frontend.

sirugh commented 3 years ago

@magento export issue to Jira project PWA as Story

github-jira-sync-bot commented 3 years ago

:white_check_mark: Jira issue (https://jira.corp.magento.com/browse/PWA-1350) is successfully created for this issue.

sirugh commented 3 years ago

Thanks for bringing this up @ankitpatel2931! I've linked this to an internal ticket so we don't lose track. This is an important feature and we want to make sure we give it adequate attention/detail. We will come back and update when we make progress on it.

supernova-at commented 3 years ago

Hey y'all, I'm closing this issue as it is encompassed in an upcoming epic. We want to put thought into- and be intentional about the design here.

karangar commented 2 years ago

Can you please provide us the files changes?

magento2demo commented 2 years ago

Please share the patch file so we can setup the product options

karangar commented 2 years ago

@magento/pwa-studio-team Anyone has Patch please share here show we can implement.

karangar commented 2 years ago

Hello team, can you please let me know? Any update for the custom option release

sanganinamrata commented 2 years ago

@magento/pwa-studio-maintainers Any updates on this feature or proposed release date?

anthoula commented 2 years ago

Hey @sanganinamrata, thank you! We recognize this as important and see multiple requests from the community. We have it in our backlog and are still finalizing the upcoming roadmap, so there is no defined release date ready to share.

tsfanning21 commented 1 year ago

Is there an update on this?

brettrootways commented 7 months ago

@magento/pwa-studio-team, is there any update on this issue?