Open Jordaneisenburger opened 4 years ago
@Jordaneisenburger I was just about to add some notes here.
We hit the same bug around April and again in September, and needed @zetlen to lend an eye to understand it. It's the directive parser for root components that trips up expecting (if I recall correctly) a single comment block only which contains the "type" information.
Created in Jira backlog for grooming/prioritization
Marked as P3S3 given available workaround (@zetlen)
@Jordaneisenburger can you confirm if this has been fixed in 8.0.0? Let's close if needed. Thanks!
Looks like it's fixed, I'll close for now.
I can confirm that this issue is not fixed. see # 2957
The issue doesn't seem to be resolved, we're running pwa studio 12.2
Describe the bug Leaving code comments in RootComponents/Category/category.js prevents webpack from running after a restart
To reproduce Steps to reproduce the behavior:
yarn run watch:venia
if (totalPagesFromData === null) { return fullPageLoadingIndicator; }
with this//
comment styleExpected behavior Run's without a problem when you comment code
Additional context It seem sto happen when the code has an
if()
statement in the code that's been commented. Now for the weirdest part: when you use multiline comments like/* */
the problem doesn't appear. So I think somewhere in the RootComponentsPlugin it somehow read's these commentsPlease complete the following device information:
npm -v
:node -v
:Please let us know what packages this bug is in regards to:
venia-concept
venia-ui
pwa-buildpack
peregrine
pwa-devdocs
upward-js
upward-spec
create-pwa