magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.07k stars 683 forks source link

[bug]:request.headers.user-agent should be useable in upward #2485

Closed fooman closed 4 years ago

fooman commented 4 years ago

Describe the bug It's currently not possible to use the following

  resolver: conditional
  when:
    - matches: request.headers.user-agent

due to the - character.

To reproduce Steps to reproduce the behavior:

  1. Create upward rule with the above

Expected behavior see pull request #2484

Please let us know what packages this bug is in regards to:

m2-assistant[bot] commented 4 years ago

Hi @fooman. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


tjwiebell commented 4 years ago

Created in internal JIRA for grooming: PWA-689