magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.06k stars 682 forks source link

[feature]: Customer account - Newsletter Subscription #2570

Closed huykon closed 4 years ago

huykon commented 4 years ago

Is your feature request related to a problem? Please describe. The customer account functions are necessary in PWA Studio, while Newsletter Subscription page is one of them.

Describe the solution you'd like Define new Magento route in PWA Studio

Additional context I will submit a PR, so this issue is just for reference.

Story Description

Sign up for email/newsletter

Design should account for sign up and managing opt-in/out not only in the "my account" section but also a general sign up form that could be located in a header/footer/content page

Note: Mocks seem to call for multiple Newsletter subscriptions but it seems the GraphQL response as of 2.4.0 only supports the single newsletter tied to is_subscribed.

Mocks

Desktop: M_Venia_Account_Communications_changesToSave_02 Mobiles: M_Venia_Account_Communications_changeToSave_02

Here are mocks of where you would find this link now as well; the Account menu has changed in this Epic.

Venia_Home_AuthAcct_Menu_04 M_Venia_AcctMenu_04

Please let us know what packages this feature is in regards to:

huykon commented 4 years ago

@magento I am working on this

m2-assistant[bot] commented 4 years ago

Hi @huykon! :wave: Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

huykon commented 4 years ago

@magento add to contributors team

m2-assistant[bot] commented 4 years ago

Hi @huykon! :wave: Thank you for joining. Please accept team invitation :point_right: here :point_left: and add your comment one more time.

tjwiebell commented 4 years ago

@huykon - We appreciate the feature request and quick PR, but you need to check in with in an internal team member before you pick up feature work that isn't groomed and prioritized on the Community Board. This does not adhere to the mocks we have for this feature, and we also have a lot of My Account work in flight that is going to change how this view functions (#2550 is the first PR up for this epic that the whole team has started working on).

Given that this view is pretty close, I'm going to see what I can do about letting the Community own this Story, but I can't make any promises. If there are any other features you're interested, please let us know, and we'll do our best to make sure it doesn't overlap with work we already have in flight internally.

huykon commented 4 years ago

@tjwiebell Thanks for your response.

tjwiebell commented 4 years ago

@huykon - if you're willing to iterate on this a little bit, @awilcoxa has agreed to let you own this feature. Tomorrow morning I'll attach some mocks to follow, as well as some implementation guidance; and will give an initial pass through your PR. You might be blocked on some requirements given this Story's position in the Epic, but I'll try to break off what's ready to go. If you have any questions I'm available on the Community Slack.

huykon commented 4 years ago

@tjwiebell Thank you. I hope to contribute this feature and my ideas for magento PWA Studio. I always here and Community Slack to see your and team core responding.

awilcoxa commented 4 years ago

Linked to PWA-285