magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.06k stars 682 forks source link

[doc]: Custom footer not success render #2623

Closed mrtuvn closed 4 years ago

mrtuvn commented 4 years ago

Describe the request run the scaffolding Follow this doc but after the end i can't render page. We should update this doc too https://magento.github.io/pwa-studio/tutorials/pwa-studio-fundamentals/modify-site-footer/

Possible solutions How would you word this addition or change?

Screenshots If applicable, add screenshots to help explain the problem. Compile success, but browser render blank white page

Screen Shot 2020-08-13 at 17 31 53

Please let us know whether this is a new topic or a topic change request:

m2-assistant[bot] commented 4 years ago

Hi @mrtuvn. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


larsroettig commented 4 years ago

@magento I am working on this

mrtuvn commented 4 years ago

@larsroettig i found missing minicart import in file src/components/App/app.js import MiniCart from '@magento/venia-ui/lib/components/MiniCart'; Seem in MacOS not raise error about missing import

larsroettig commented 4 years ago

@mrtuvn This tutorial is from point of view updated should be removed is not good praxis to overwrite 3 components to get a different Footer.

in this tutorial, I show how you can things with a minimal effect on your theme Also, I can recommend using https://github.com/fooman/venia-ui-override-resolver

Blogpost: https://larsroettig.dev/getting-started-with-pwa-studio-extensibility/

mrtuvn commented 4 years ago

thanks for your response. But i think we should update content (correct some wrong path) and possible add some related links for new guys

larsroettig commented 4 years ago

@jcalcaben what do think we should mark these Tutorials as outdated or remove the outdated tutorials I don't like that we referencing not good approaches in official docs. Junior People that are new to Webpack and React thing about let's do like in the Tutorial and do think is there a better way.

jcalcaben commented 4 years ago

I agree. Outdated tutorials are not a good developer experience. I try to identify and update content as they become outdated, and I also appreciate the community's help with this. I'm happy work with anyone who wants to help fix our docs.

awilcoxa commented 4 years ago

Created PWA-863