[feature]: Idea for static code analysis of PWA Stduio modules

[larsroettig]

Is your feature request related to a problem? Please describe.

All PWA modules should be checked for consistency through a validation process. This should work similarly to the Magento Coding Style an idea would be to build an eslint rule

Describe the solution you'd like

Idea we parse package.json check for "pwa-studio": {"targets": { "intercept" there is defined if it is an PWA Extensions.

We add this folder to our validation process the every PWA Extensions need the esModules flag in the intercept file. Also we search if contains the module any .css or .graphql then flags cssModules flag or graphqlQueries flag are required.

I think what we also should check if a .js contains an import for @magento/peregrine but is it is not defined as peerDependencies then we should throw an error for missing peer dependencies.

Describe alternatives you've considered

Additional context

Please let us know what packages this feature is in regards to:

• [ ] venia-concept
• [ ] venia-ui
• [ ] pwa-buildpack
• [ ] peregrine
• [ ] pwa-devdocs
• [ ] upward-js
• [ ] upward-spec
• [ ] create-pwa

[m2-assistant[bot]]

Hi @larsroettig. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[larsroettig]

@zetlen what do think about this?

[awilcoxa]

Created PWA-868