[feature]: Replace ProductQuantity on Product Page with QuantityFields stepper - Githubissues

magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.

https://developer.adobe.com/commerce/pwa-studio/

Open Software License 3.0

1.07k stars 683 forks source link

[feature]: Replace ProductQuantity on Product Page with QuantityFields stepper #2679

Closed tjwiebell closed 4 years ago

tjwiebell commented 4 years ago

Description

The quantity selector on PDP and cart don't currently match either in the way they look or in the way they behave.

The cart stepper is the latest design, and the quantity selector on PDP should be updated to match this.

Acceptance Criteria

ProductQuantity is deprecated and replaced with quantity stepper component currently on CartPage (you will want to use QuantityFields, much like the product edit usage)
Unit tests are updated to reflect expected view changes
(Optional) The quantity stepper is probably general use enough that it can be moved to the components directory so it becomes API. Discuss with @tjwiebell if interested in this re-factor.

Internal JIRA Links

[PWA-591] Replace quantity selector on PDP to match cart stepper

Please let us know what packages this feature is in regards to:

[ ] venia-concept
[x] venia-ui
[ ] pwa-buildpack
[x] peregrine
[ ] pwa-devdocs
[ ] upward-js
[ ] upward-spec
[ ] create-pwa

m2-assistant[bot] commented 4 years ago

Hi @tjwiebell. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

huykon commented 4 years ago

@magento I am working on this

awilcoxa commented 4 years ago

Linked to JIRA PWA-918