magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.07k stars 683 forks source link

[bug]: Minicart is missing on /checkout #2733

Closed Jordaneisenburger closed 4 years ago

Jordaneisenburger commented 4 years ago

Describe the bug When you go to /checkout you are not able to edit your cart. I'm aware this is done on purpose probably for the reason of the "no distractions in checkout" rule. But In that case I feel you either need to minimize the whole header or keep the minicart trigger in the header. Pretty sure most agencies are gonna swap it back anyway.

This is for example how we've done it. Screenshot 2020-09-28 at 13 47 38

To reproduce Steps to reproduce the behavior:

  1. Add item to cart
  2. Go to checkout
  3. Try to edit your cart

Expected behavior I'd expect there to be a option to edit my cart in the checkout.

Screenshots

Additional context

Possible solutions Also show the minicart on the checkout page

Please complete the following device information:

Please let us know what packages this bug is in regards to:

m2-assistant[bot] commented 4 years ago

Hi @Jordaneisenburger. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


sirugh commented 4 years ago

As you already stated, we intentionally hide the mini cart trigger on the checkout page. We went back and forth on it but I think the decision was honestly split. It would be trivial to add back but I think we need to consider the options such as:

a) hiding the entire header on /checkout b) hiding all clickable/actionable elements from the header on /checkout

So I would not consider this a bug but a feature request. And for folks who want to display the mini cart trigger, they just need to extend the talon and always return hideCartTrigger: false or customize their component and ignore the boolean return from the talon.

Jordaneisenburger commented 4 years ago

Your right it should be a feature request since it was intentionally hidden. I personally don't see why removing this functionality would improve checkout experience. But then again I'm not a UX designer so if you guys have already had discussions about this we can close it.