search

magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.07k stars 684 forks source link

[doc]: Page builder to PWA integration documentation is out of date #2864

Open Frodigo opened 4 years ago

Frodigo commented 4 years ago

Describe the request These docs are out of date:

  1. https://magento.github.io/pwa-studio/pagebuilder/custom-components/overview/

Your Magento instance should have a custom content type added and saved to the home page in the Admin. Currently, the home page is the only page you can render Page Builder content within PWA Studio.

That is not true. Now it's possible to render page builder components on other CMS pages than Homepage.

  1. https://magento.github.io/pwa-studio/pagebuilder/custom-components/setup-component/

Configuring your component is about connecting your component to the Page Builder component framework. The framework provides a static config object (in config.js) that acts as a kind of registry of content types supported within PWA Studio. To include support for your custom content type component, you’ll need to add an entry to the config.js:

Open the config.js file and import your configAggregator. The import statement for our ExampleQuote is shown here

This is not possible now because PageBuilder has become a separate module and its files are in the directory under node_modules and we cannot edit its files directly.

Please let us know whether this is a new topic or a topic change request:

m2-assistant[bot] commented 4 years ago

Hi @Frodigo. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this