[bug]: Filter labels don't update

magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.

https://developer.adobe.com/commerce/pwa-studio/

Open Software License 3.0

1.06k stars 682 forks source link

[bug]: Filter labels don't update #2875

Open KevinGorjan opened 3 years ago

KevinGorjan commented 3 years ago

Is your feature request related to a problem? Please describe. When I change the filter label name (ex: Price to Price_updated) it doesn't update the label in Venia.

Describe the solution you'd like I think the GraphQL should be updated or there is something going wrong in the frontend

Describe alternatives you've considered none

Additional context

Please let us know what packages this feature is in regards to:

[x] venia-concept
[x] venia-ui
[ ] pwa-buildpack
[ ] peregrine
[ ] pwa-devdocs
[ ] upward-js
[ ] upward-spec
[ ] create-pwa

m2-assistant[bot] commented 3 years ago

Hi @KevinGorjan. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

sirugh commented 3 years ago

@KevinGorjan If you're able to, could you provide me with the data from the network response for the GetProductFiltersByCategory query? You can see in the below screenshot from develop that we use the aggregations label as the rendered text for the filter. My theory is that either there is a bug in GQL or we are not using the correct label/attribute to render the filter item.