search

magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.07k stars 683 forks source link

Wrong verbiage in account create warning #2994

Closed mohanelamurugan closed 3 years ago

mohanelamurugan commented 3 years ago

After enabling account confirmation through email, Warning message verbiage is wrong

To reproduce

Steps to reproduce the behavior:

  1. Login to admin panel
  2. Navigate to Stores > Configuration
  3. Go to Customers > Customer Configuration
  4. Click “Create New Account Option“
  5. Set “yes” in Require Email Confirmation
  6. Save the configuration.
  7. Register a new account from storefront.
  8. Now, After registering a new account, Instead of saying "Account is not confirmed", It says "Account is locked". Exact verbiage is given below

Expected behavior The warning verbiage should be "This account is not confirmed. <a href=""%1"">Click here to resend confirmation email.","This account is not confirmed. <a href=""%1"">Click here to resend confirmation email."

Actual behavior The warning verbiage is "The account sign in was incorrect or your account is disabled completely. please wait and try again later"

Screenshot

emailreg

m2-assistant[bot] commented 3 years ago

Hi @mohanelamurugan. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

sirugh commented 3 years ago

Hi @mohanelamurugan thanks for reporting this issue. Unfortunately, this is not a bug with PWA Studio but is an issue with the magento graphql response to the signIn mutation. In this case, PWA Studio renders the exact graphql error message into the error container. So this message comes from the backend.

Please open an issue against the magento2 repo. You can reference this issue if you like. I would also suggest adding the graphql response from the network tab in your developer tools after you attempt the sign in. It should contain the error message in the response.