search

magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.07k stars 684 forks source link

[feature]: Clean up duplicated code between credit card and billing address #3066

Open sirugh opened 3 years ago

sirugh commented 3 years ago

Is your feature request related to a problem? Please describe. In #2969 we copied a bunch of logic from credit card to a separate component, BillingAddress. To reduce the scope in that work, we did not de-dupe the work.

Describe the solution you'd like This ticket should go through the credit card component and talon and try to clean it up to use the approach now implemented at least by the extensions.

Describe alternatives you've considered None :)

Additional context Just look through the credit card components/talons and the billing address components/talons and you should find duplicate code.

m2-assistant[bot] commented 3 years ago

Hi @sirugh. Thank you for your report. To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

sirugh commented 3 years ago

@magento export issue to JIRA project PWA as Story

github-jira-sync-bot commented 3 years ago

:white_check_mark: Jira issue (https://jira.corp.magento.com/browse/PWA-1585) is successfully created for this issue.