magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.07k stars 684 forks source link

Country details blocking Shipping Address saving on Venia PWA #345

Closed ericerway closed 6 years ago

ericerway commented 6 years ago

image

Checkout is blocked when using UK-based Cloud of 2.3.0 (https://mage23.merewood.org) on Venia PWA which affects "country" and disables how a Shipping Address is saved. Screenshot attached.

Upon resolution this should allow a complete purchase.

Starotitorov commented 6 years ago

I took a look at our code and found the reason of the issue, I am going to create a pull request. Also right now we implemented support only for regions code, so after my fix if you enter MI it should work. Do we also need to add support of full region names, we just need to edit this line https://github.com/magento-research/pwa-studio/blob/release/2.0/packages/venia-concept/src/actions/checkout/asyncActions.js#L119?

Pull request https://github.com/magento-research/pwa-studio/pull/383

ericerway commented 6 years ago

I took a look at our code and found the reason of the issue, I am going to create a pull request. Also right now we implemented support only for regions code, so after my fix if you enter MI it should work. Do we also need to add support of full region names, we just need to edit this line https://github.com/magento-research/pwa-studio/blob/release/2.0/packages/venia-concept/src/actions/checkout/asyncActions.js#L119?

Pull request #383

Thanks @Starotitorov - for MVP let's keep to US but need to expand to a global form right after this release. As a reference storefront this can be extended to any region we are just providing an example here. Thanks again!

Starotitorov commented 6 years ago

Eric, now we support not only US, we support other countries too. But we search region information using only state code that consists of 2 letters, we can also implement searching by full state name.

ericerway commented 6 years ago

Understood, thanks for the clarification with the new reducer. Looking forward to seeing this tested and merged. Thanks!

zetlen commented 6 years ago

Closed by #383.

zetlen commented 6 years ago

That is, fixed by it. Thanks @Starotitorov !