Closed ericerway closed 5 years ago
Spitballing some notes/ideas/planning around this:
Icon
component we probably cannot utilize tree-shaking OOTB. With a different icon package we may be able to do away with the Icon
component and import specific icons.Thanks for the readout @sirugh -- @jimbo can help with the rationale and collaboration on which option to move forward with on this one.
This issue is for the following packages:
[X]
venia-concept
[ ]pwa-buildpack
[X]peregrine
[ ]pwa-devdocs
[ ]upward-js
[ ]upward-spec
This issue is a:
[ ] Bug [ ] Feature suggestion [ ] Documentation issue [X] Other (Please Specify)
Environment
node -v
)npm -v
)Description
Continued review of Javascript size should include our use of feather-icons for Venia to ensure high performance for our reference storefront in PWA.
Expected result:
[ ] Summary of results; recommended improvements [ ] Creation of new issues/stories (as appropriate)
Possible solutions:
[ ] Optimization of current library to remove unused icons (preferred) [ ] Review of alternate icon fonts/libraries for performance