magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.06k stars 682 forks source link

Review icon fonts/library for performance improvements [SPIKE] #376

Closed ericerway closed 5 years ago

ericerway commented 5 years ago

This issue is for the following packages:

[X] venia-concept [ ] pwa-buildpack [X] peregrine [ ] pwa-devdocs [ ] upward-js [ ] upward-spec

This issue is a:

[ ] Bug [ ] Feature suggestion [ ] Documentation issue [X] Other (Please Specify)

Environment

Question Answer
Magento version
Operating System + version
node.js version (node -v)
npm version (npm -v)

Description

Continued review of Javascript size should include our use of feather-icons for Venia to ensure high performance for our reference storefront in PWA.

Expected result:

[ ] Summary of results; recommended improvements [ ] Creation of new issues/stories (as appropriate)

Possible solutions:

[ ] Optimization of current library to remove unused icons (preferred) [ ] Review of alternate icon fonts/libraries for performance

sirugh commented 5 years ago

Spitballing some notes/ideas/planning around this:

Webpack Bundle Stats

With feather-icons, ~17kb gzipped: Image from Gyazo

With react-feather, ~1kb gzipped (with specified imports): Image from Gyazo

ericerway commented 5 years ago

Thanks for the readout @sirugh -- @jimbo can help with the rationale and collaboration on which option to move forward with on this one.