magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.07k stars 683 forks source link

PWA-3047::[bug]: PWA Scaffolding Tool uses old version #4118

Closed glo82145 closed 1 year ago

glo82145 commented 1 year ago

Description

Describe the bug

Using the create PWA scaffolding tool appears to use an old version. This appears it is related to issue #4009 that was closed without resolution.

To reproduce

Steps to reproduce the behavior:

Run the yarn create @magento/pwa or npx @magento/create-pwa command Note that during the questionnaire portion the prompt only includes mention of Magento 2.3.3 and 2.4-develop

? Magento instance to use as a backend (will be added to .env file) (Use arrow keys) ❯ Magento 2.3.3 with Venia sample data installed Magento 2.4-develop with Venia sample data installed Other (I will provide my own backing Magento instance) Regardless of which option you select the generated .env file includes the following (note the mention of "Magento 2.3"... `{{ Connecting to a Magento store ############################################# # Connect to an instance of Magento 2.3 by specifying its public domain name. MAGENTO_BACKEND_URL=https://venia-develop-ccewfjy-mfwmkrjfqvbjk.us-4.magentosite.cloud/ # ################################################################################ }}{{ Additionally, if selecting }}2.4-develop{{ the generated cloud instance url does not work after running }}yarn watch{{ (as mentioned in #4009) Expected behavior

I would expect to not see a reference to }}2.4-develop{{ in the questionnaire, }}2.3{{ in the }}.env{{ file, and the generated 2.4 }}MAGENTO_BACKEND_URL{{ should work.

Related Issue

Closes PWA-3047

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

pwa-studio-bot commented 1 year ago
Fails
:no_entry_sign: A version label is required. A maintainer must add one.
Messages
:book: Associated JIRA tickets: [PWA-3047](https://jira.corp.magento.com/browse/PWA-3047).
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book: Access a deployed version of this PR [here](https://pr-4118.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by :no_entry_sign: dangerJS against e412420004790c69e2f3af0d92c7a2ab110d47ba

glo82145 commented 1 year ago

run lighthouse-desktop

pwa-test-bot[bot] commented 1 year ago

Successfully started codebuild job for lighthouse-desktop

glo82145 commented 1 year ago

run lighthouse-mobile

pwa-test-bot[bot] commented 1 year ago

Successfully started codebuild job for lighthouse-mobile