magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.07k stars 683 forks source link

PWA-3137-V3::Image is rendered on wrong pages when parallax is used o… #4129

Closed glo80771 closed 1 year ago

glo80771 commented 1 year ago

…n page builder

Description

If a row added in pagebuilder contains a background image configured with the parallax option, the image will show up on other pages even if the row was not added to the page in question. This issue is not reproducible on LUMA, only on PWA.

Related Issue

Closes https://jira.corp.adobe.com/browse/PWA-3137.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

pwa-studio-bot commented 1 year ago
Messages
:book: Associated JIRA tickets: [PWA-3137](https://jira.corp.magento.com/browse/PWA-3137).
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book: Access a deployed version of this PR [here](https://pr-4129.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by :no_entry_sign: dangerJS against 8b62ef4b131fc09c32abf1c82a114f21b4b24ad8

glo82145 commented 1 year ago

run lighthouse-desktop

pwa-test-bot[bot] commented 1 year ago

Successfully started codebuild job for lighthouse-desktop

glo82145 commented 1 year ago

run lighthouse-mobile

pwa-test-bot[bot] commented 1 year ago

Successfully started codebuild job for lighthouse-mobile