pwa-studio-bot
commented
1 year ago | Fails | |
|---|---|
| :no_entry_sign: | `node` failed. |
| :no_entry_sign: |
Unit tests in the following files did _not_ pass 😔. All tests must pass before this PR can be merged
|
| :no_entry_sign: | The following file(s) were not formatted with **prettier**. Make sure to execute `yarn run prettier` locally prior to committing. ``` packages/peregrine/lib/talons/FilterModal/helpers.js ``` |
| Messages | |
|---|---|
| :book: | Associated JIRA tickets: [PWA-3162](https://jira.corp.magento.com/browse/PWA-3162). |
| :book: | DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed). |
| :book: | Access a deployed version of this PR [here](https://pr-4140.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete. |
Log
ERROR ON TASK: prettierCheck
ERROR ON TASK: unitTests
Error: Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.jsonGenerated by :no_entry_sign: dangerJS against 331ce84d44a905572a84b279cdcf83c8bb9b14d1
Description
In the event that a different price filter is applied after a price filter is already applied, the query will only be for the first price filter, not the combination of the two.
This behavior might be interpreted as a bug but is actually a mis-implementation of the UI for the price filter which only allows a "range" ie {{
{ "from": "0", "to": "100" } }}.
Related Issue
Closes https://jira.corp.adobe.com/browse/PWA-3162
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist