magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.06k stars 682 forks source link

VULN-25329: Removing obsolete docs directory #4144

Closed jeff-matthews closed 1 year ago

jeff-matthews commented 1 year ago

Description

This pull request (PR) deletes the pwa-devdocs/ directory from the project.

Documentation was migrated to the https://github.com/AdobeDocs/commerce-pwa-studio repo and that's where it is actively maintained. That's also the source that we deploy to production.

Related Issue

VULN-25329

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

pwa-studio-bot commented 1 year ago
Fails
:no_entry_sign: node` failed.
:no_entry_sign: A version label is required. A maintainer must add one.
:no_entry_sign: Unable to create scaffolded project. ``` DEBUG_PROJECT_CREATION=1 packages/create-pwa/bin/create-pwa ``` failed. Learn more about Scaffolding at https://magento.github.io/pwa-studio/pwa-buildpack/scaffolding/.
Messages
:book: Associated JIRA tickets: [VULN-25329](https://jira.corp.magento.com/browse/VULN-25329).
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book: Access a deployed version of this PR [here](https://pr-4144.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: eslintCheck

ERROR ON TASK: scaffoldingSucceeds


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by :no_entry_sign: dangerJS against 4c2477bfc533ecafa0cce5cb5ad9367de913c5ff

jeff-matthews commented 1 year ago

I'm not sure why it's showing merge conflicts. I'm also not sure how to resolve them.

jeff-matthews commented 1 year ago

Oh, I know what happened. I used the wrong branch in my fork. I'll open a new PR.

jeff-matthews commented 1 year ago

See https://github.com/magento/pwa-studio/pull/4146