magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.06k stars 682 forks source link

PWA-3117::[PWA] display number of items in cart instead of quantities… #4149

Closed glo82145 closed 11 months ago

glo82145 commented 1 year ago

Preconditions Leave only Yes or No as the answer

Issue is reproducible on the latest mainline, without Sample Data: Yes JIRA was checked for similar/duplicated issues: Yes GitHub project was checked: Yes Merchdocs and Devdocs were checked: Yes Double Check List L3 was checked: Yes Steps to reproduce

Install PWA studio with [ 2.4-develop ]

Check the [ Display Cart Summary ] configuration from [ Store > Configuration > Sales > Checkout > My Cart Link > Display Cart Summary ]. The default value should available as [ Display item quantities ]

Create a simple product from the backend

Add 5 quantities to cart from the above product. The minicart will display like below. Which is correct with the default [ Display Cart Summary ] configuration.

Change the [ Display Cart Summary ] configuration to [ Display number of items in cart ]

Remove items from the shopping cart and again add 5 quantities from the same product

Check the mini-cart product count

Actual results Minicart still displays [ 5 ].

Expected results When we set [ Display Cart Summary ] configuration to [ Display number of items in cart ], it should not display the item quantity. The value it should display is [ 1 ], which is the number of unique items in the cart.

Closes #PWA-3117

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

pwa-studio-bot commented 1 year ago
Fails
:no_entry_sign: Missing "Description" section. Please add it back, with detail.
Messages
:book: Associated JIRA tickets: [PWA-3117](https://jira.corp.magento.com/browse/PWA-3117).
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book: Access a deployed version of this PR [here](https://pr-4149.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by :no_entry_sign: dangerJS against f6182ccc7033bd6f65ee19f84750af62f23cee7e

glo82145 commented 11 months ago

run lighthouse-desktop

pwa-test-bot[bot] commented 11 months ago

Successfully started codebuild job for lighthouse-desktop

glo82145 commented 11 months ago

run lighthouse-mobile

pwa-test-bot[bot] commented 11 months ago

Successfully started codebuild job for lighthouse-mobile