magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.07k stars 683 forks source link

[bug]: Customer signin_token purged on refresh #4152

Closed qburst-arjunsreedhar closed 3 months ago

qburst-arjunsreedhar commented 1 year ago

Describe the bug

A clear and concise description of what the bug is.

To reproduce

Steps to reproduce the behavior:

  1. Login as a customer in PWA store
  2. Set the token in storage using the BrowserPersistence util with key 'signin_token'.
  3. Refresh the page

Expected behavior

The token should be retained in the localStorage but it is purged.

Please complete the following device information:

Please let us know what packages this bug is in regards to:

m2-assistant[bot] commented 1 year ago

Hi @qburst-arjunsreedhar. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information. Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

RaghavendraTirumalasetti commented 1 year ago

Hi @qburst-arjunsreedhar, As per testing, we are not able to reproduce the issue with the latest pwa local instance and also https://venia.magento.com/.

PFA for the screenshot:

Screenshot 2023-08-28 at 7 47 19 PM
qburst-arjunsreedhar commented 1 year ago

Hey @RaghavendraTirumalasetti,

I was able to fix this issue by calling the handleSubmit function returned by the useSignIn talon but if I do not use this method and directly insert the token to localStorage this issue occurs.

glo82145 commented 6 months ago

@adobe export issue to Jira project PWA

glo82145 commented 6 months ago

@adobe export issue to Jira project PWA

github-jira-sync-bot commented 6 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/PWA-3278 is successfully created for this GitHub issue.

glo85315 commented 3 months ago

Hi @qburst-arjunsreedhar,

Following our recent testing, we were unable to reproduce the issue using both the latest PWA local instance and the live site at https://venia.magento.com/.

https://github.com/user-attachments/assets/df3e6584-6686-4d31-86c4-a596aa8a597f

glo42707 commented 3 months ago

clsoing this issue since it is not reproducible at pwa end and reporter was able to fix it in his end as per above comment https://github.com/magento/pwa-studio/issues/4152#issuecomment-1700706070