magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.06k stars 682 forks source link

Adding devcontainer to Venia Concept #4171

Open rafaelstz opened 12 months ago

rafaelstz commented 12 months ago

Many devs in my team and community report issues installing PWA Studio in their local environments. The issues are mainly related to DNS, Node or Yarn version, ports in use, etc. Adding devcontainer to Venia Concept will make it much easier to start developing after yarn create @magento/pwa.

It has Node 18 LTS and a small Nodejs Docker image made exclusively for VSCode and CodeSpace.

The next step would be adding guidance on DevDocs. I will do it when the PR is merged.

Screenshot 2023-09-20 135022

pwa-studio-bot commented 12 months ago
Fails
:no_entry_sign: `node` failed.
:no_entry_sign: A version label is required. A maintainer must add one.
:no_entry_sign: Unable to build scaffolded project. ``` yarn build ``` within a scaffolded project directory failed. Learn more about Scaffolding at https://magento.github.io/pwa-studio/pwa-buildpack/scaffolding/.
:no_entry_sign: No linked issue found. Please link a relevant open issue by adding the text "closes #" or "closes JIRA-" in your PR.
:no_entry_sign: Missing "Verification Steps" section. Please add it back, with detail.
:no_entry_sign: Missing "Description" section. Please add it back, with detail.
Messages
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book: Access a deployed version of this PR [here](https://pr-4171.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: scaffoldingSucceeds


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by :no_entry_sign: dangerJS against aec3ad901c53bbdce991fbe3ceb29ae3149b7681