search

magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.06k stars 682 forks source link

PWA-3208::getting error on address page Unable to proceed checkout as… #4174

Closed glo80771 closed 11 months ago

glo80771 commented 11 months ago

… guest/registered user with my local instance after pulling latest changes

Description

Steps to Reproduce

  1. Use local magento URL with prerequisites as backend server into .env of pwa
  2. Checkout to devlop server and install checkmo using command "yarn venia add -D @magento/venia-sample-payments-checkmo"
  3. now yarn install and yarn build and yarn stage:venia
  4. pickup URL and try to checkout with one of product
  5. observe if any error while clicking on shipping button from shipping address page

Expected Result

  1. User should be able to complete checkout without any issue
  2. User should be able to create user without any issues.

Actual Result

  1. getting error while clicking on shipping here on shipping address and unable to move to next screen
  2. Unable to create new user

Related Issue

Closes https://jira.corp.adobe.com/browse/PWA-3208.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

pwa-studio-bot commented 11 months ago
Fails
:no_entry_sign: A version label is required. A maintainer must add one.
Messages
:book: Associated JIRA tickets: [PWA-3208](https://jira.corp.magento.com/browse/PWA-3208).
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book: Access a deployed version of this PR [here](https://pr-4174.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by :no_entry_sign: dangerJS against 864a6df08bba308e0204995fcb65ff2a684be41e

glo82145 commented 11 months ago

run lighthouse-desktop

pwa-test-bot[bot] commented 11 months ago

Successfully started codebuild job for lighthouse-desktop

glo82145 commented 11 months ago

run lighthouse-mobile

pwa-test-bot[bot] commented 11 months ago

Successfully started codebuild job for lighthouse-mobile

seyuf commented 2 hours ago

@glo05548 unfortunately this invalidates the previous commit fixing issues when a country region is not required https://github.com/magento/pwa-studio/commit/e3a97e2180115995985707ad034c9d1d6621f82b

seyuf commented 2 hours ago

Also this merge doesn't make any sense. You say you have issues with address on logged user. But the code you're modifying should only impact guests. Why is this merge without secondary review, anyway? Smells fishy...