search

magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.06k stars 682 forks source link

Pwa3162 v4 #4179

Closed glo82145 closed 11 months ago

glo82145 commented 11 months ago

Description

TODO: Describe your changes in detail here.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

pwa-studio-bot commented 11 months ago
Fails
:no_entry_sign: `node` failed.
:no_entry_sign: A version label is required. A maintainer must add one.
:no_entry_sign: Unable to build scaffolded project. ``` yarn build ``` within a scaffolded project directory failed. Learn more about Scaffolding at https://magento.github.io/pwa-studio/pwa-buildpack/scaffolding/.
:no_entry_sign: Unit tests in the following files did _not_ pass 😔. All tests must pass before this PR can be merged
  • packages/pwa-buildpack/lib/WebpackTools/targetables/__tests__/TargetableReactComponent.spec.js
  • packages/venia-ui/lib/components/FilterModal/FilterList/__tests__/filterList.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/targetables/BabelModifyJSXPlugin/__tests__/JSXSnippetParser.spec.js
  • packages/venia-ui/lib/RootComponents/Category/__tests__/categoryContent.shimmer.spec.js
:no_entry_sign: No linked issue found. Please link a relevant open issue by adding the text "closes #" or "closes JIRA-" in your PR.
:no_entry_sign: Missing information in PR. Please fill out the "Description" section.
Warnings
:warning: Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book: Access a deployed version of this PR [here](https://pr-4179.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: unitTests

ERROR ON TASK: scaffoldingSucceeds


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by :no_entry_sign: dangerJS against ec0cdaf62884518c881f140f8835224323d1c4d5