magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.06k stars 682 forks source link

Sync main #4184

Closed glo82145 closed 11 months ago

glo82145 commented 11 months ago

Description

TODO: Describe your changes in detail here.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

pwa-studio-bot commented 11 months ago
Fails
:no_entry_sign: Whoops! Pull requests should be opened against `develop`, not `main`. Please reopen this PR against the correct branch.
:no_entry_sign: A version label is required. A maintainer must add one.
:no_entry_sign: No linked issue found. Please link a relevant open issue by adding the text "closes #" or "closes JIRA-" in your PR.
:no_entry_sign: Missing information in PR. Please fill out the "Description" section.
Warnings
:warning: Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book: Access a deployed version of this PR [here](https://pr-4184.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete.

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by :no_entry_sign: dangerJS against ec5f2541229389e215ebf27f4d64a470ceada6e9

pwa-studio-bot commented 11 months ago
Fails
:no_entry_sign: `node` failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by :no_entry_sign: dangerJS against ec5f2541229389e215ebf27f4d64a470ceada6e9

pwa-studio-bot commented 11 months ago
Fails
:no_entry_sign: `node` failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by :no_entry_sign: dangerJS against ec5f2541229389e215ebf27f4d64a470ceada6e9

pwa-studio-bot commented 11 months ago
Fails
:no_entry_sign: `node` failed.

Log

``` Error: Error: Cannot find module './.lighthouseci/assertion-results.json' Require stack: - dangerfile.lighthouse.js - /usr/local/share/.config/yarn/global/node_modules/danger/distribution/runner/runners/inline.js - /usr/local/share/.config/yarn/global/node_modules/danger/distribution/commands/danger-runner.js ``` ERROR ON TASK: lighthouseTests ``` Error: Danger had errors running. See message(s) above for more details. danger-results://tmp/danger-results-876cc8f3.json ```

Generated by :no_entry_sign: dangerJS against ec5f2541229389e215ebf27f4d64a470ceada6e9

pwa-studio-bot commented 11 months ago
Fails
:no_entry_sign: `node` failed.

Log

``` Error: Error: Cannot find module './.lighthouseci/assertion-results.json' Require stack: - dangerfile.lighthouse.js - /usr/local/share/.config/yarn/global/node_modules/danger/distribution/runner/runners/inline.js - /usr/local/share/.config/yarn/global/node_modules/danger/distribution/commands/danger-runner.js ``` ERROR ON TASK: lighthouseTests ``` Error: Danger had errors running. See message(s) above for more details. danger-results://tmp/danger-results-8299e9cd.json ```

Generated by :no_entry_sign: dangerJS against ec5f2541229389e215ebf27f4d64a470ceada6e9