magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.06k stars 682 forks source link

PWA-3217::Thumbnail Images are getting hidden due to PR - BUG#PWA-3215 #4193

Closed glo80771 closed 10 months ago

glo80771 commented 10 months ago

Description

Thumbnail Images are getting hidden due to PR - BUG#[PWA-3215].

Related Issue

Closes https://jira.corp.adobe.com/browse/PWA-3215.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

pwa-studio-bot commented 10 months ago
Fails
:no_entry_sign: `node` failed.
:no_entry_sign: Unit tests in the following files did _not_ pass 😔. All tests must pass before this PR can be merged
  • packages/pwa-buildpack/lib/WebpackTools/targetables/__tests__/TargetableReactComponent.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/targetables/BabelModifyJSXPlugin/__tests__/JSXSnippetParser.spec.js
:no_entry_sign: The following file(s) did not pass **ESLint**. Execute `yarn run lint` locally for more details ``` packages/venia-ui/lib/components/Image/resourceImage.js ```
:no_entry_sign: The following file(s) were not formatted with **prettier**. Make sure to execute `yarn run prettier` locally prior to committing. ``` packages/venia-ui/lib/components/Image/resourceImage.js ```
Messages
:book: Associated JIRA tickets: [PWA-3215](https://jira.corp.magento.com/browse/PWA-3215).
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book: Access a deployed version of this PR [here](https://pr-4193.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: prettierCheck

ERROR ON TASK: eslintCheck

ERROR ON TASK: unitTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by :no_entry_sign: dangerJS against 3152c8aae8b5c7275eb67fb4bd72676997f3e679

glo80771 commented 10 months ago

Not used