magento / pwa-studio

šŸ› Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.06k stars 682 forks source link

PWA-3227::yarn install broken after #4191 #4207

Closed glo80771 closed 6 months ago

glo80771 commented 9 months ago

Description

yarn install v1.22.19 warning package-lock.json found. Your project contains lock files generated by tools other than Yarn. It is advised not to mix package managers in order to avoid resolution inconsistencies caused by unsynchronized lock files. To clear this warning, remove package-lock.json.

To reproduce

Steps to reproduce the behavior:

run yarn install Expected behavior

no error

Related Issue

https://jira.corp.adobe.com/browse/PWA-3227.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

pwa-studio-bot commented 9 months ago
Messages
:book: Associated JIRA tickets: [PWA-3227](https://jira.corp.magento.com/browse/PWA-3227).
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book: Access a deployed version of this PR [here](https://pr-4207.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by :no_entry_sign: dangerJS against c646e8a3ac3b7b1918c356a06d22634ad079d413

glo82145 commented 9 months ago

run lighthouse-desktop

glo82145 commented 9 months ago

run lighthouse-desktop

glo82145 commented 9 months ago

run lighthouse-desktop

dpatil-magento commented 9 months ago

run lighthouse-desktop