Closed glo82145 closed 3 months ago
run pr-deploy
Successfully started codebuild job for pr-deploy
run pr-test
Successfully started codebuild job for pr-test
Fails | |
---|---|
:no_entry_sign: | `node` failed. |
:no_entry_sign: | Unable to build scaffolded project. ``` yarn build ``` within a scaffolded project directory failed. Learn more about Scaffolding at https://magento.github.io/pwa-studio/pwa-buildpack/scaffolding/. |
:no_entry_sign: |
Unit tests in the following files did _not_ pass 😔. All tests must pass before this PR can be merged
|
Messages | |
---|---|
:book: | Associated JIRA tickets: [PWA-3216](https://jira.corp.magento.com/browse/PWA-3216). |
:book: | DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed). |
:book: | Access a deployed version of this PR [here](https://pr-4218.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete. |
ERROR ON TASK: unitTests
ERROR ON TASK: scaffoldingSucceeds
Error: Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json
Generated by :no_entry_sign: dangerJS against f5e759ce8976ab26a6c40b8f22b6e3661e127771
Description
need to upgrade Node support >=18 for PWA studio package as per Node updates no more availbale for support for lower version as per link https://endoflife.date/nodejs
Prerequisite- Node >=18 should be installed for PWA setup
Description: as if now PWA lower support is by default >=14 as per informattion can see on https://github.com/magento/pwa-studio/blob/76fbf76fc1afce2b244d3f647164dbf60b7da070/package.json#L101
Actual Result:- Current Node version support for PWA studio is >=14
Expected: Default Node version need to be updated in PWA package as >=18
Related Issue
Closes (https://jira.corp.adobe.com/browse/PWA-3216)
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist