search

magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.06k stars 682 forks source link

PWA-3216 upgrading node to >=18 #4218

Closed glo82145 closed 3 months ago

glo82145 commented 9 months ago

Description

need to upgrade Node support >=18 for PWA studio package as per Node updates no more availbale for support for lower version as per link https://endoflife.date/nodejs

Prerequisite- Node >=18 should be installed for PWA setup

Description: as if now PWA lower support is by default >=14 as per informattion can see on https://github.com/magento/pwa-studio/blob/76fbf76fc1afce2b244d3f647164dbf60b7da070/package.json#L101

Actual Result:- Current Node version support for PWA studio is >=14

Expected: Default Node version need to be updated in PWA package as >=18

Related Issue

Closes (https://jira.corp.adobe.com/browse/PWA-3216)

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

glo82145 commented 5 months ago

run pr-deploy

pwa-test-bot[bot] commented 5 months ago

Successfully started codebuild job for pr-deploy

glo82145 commented 3 months ago

run pr-test

pwa-test-bot[bot] commented 3 months ago

Successfully started codebuild job for pr-test

pwa-studio-bot commented 3 months ago
Fails
:no_entry_sign: `node` failed.
:no_entry_sign: Unable to build scaffolded project. ``` yarn build ``` within a scaffolded project directory failed. Learn more about Scaffolding at https://magento.github.io/pwa-studio/pwa-buildpack/scaffolding/.
:no_entry_sign: Unit tests in the following files did _not_ pass 😔. All tests must pass before this PR can be merged
  • packages/peregrine/lib/targets/__tests__/peregrine-targets.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/__tests__/PWADevServer.spec.js
  • packages/pagebuilder/lib/ContentTypes/Banner/__tests__/banner.spec.js
  • packages/venia-ui/lib/components/ProductFullDetail/__tests__/productFullDetail.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/__tests__/checkoutPage.spec.js
  • packages/pwa-buildpack/lib/Utilities/__tests__/configureHost.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/__tests__/configureWebpack.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/OrderDetails/__tests__/orderDetails.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/targetables/__tests__/TargetableReactComponent.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/__tests__/splice-source-loader.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/plugins/__tests__/LocalizationPlugin.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/plugins/__tests__/RootComponentsPlugin.spec.js
  • packages/venia-ui/lib/targets/__tests__/venia-ui-targets.spec.js
  • packages/venia-ui/lib/components/ProductImageCarousel/__tests__/carousel.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/targetables/__tests__/TargetableModule.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/paymentsForm.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/plugins/__tests__/ServiceWorkerPlugin.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceSummary/__tests__/priceSummary.spec.js
  • packages/venia-ui/lib/components/CartPage/ProductListing/__tests__/product.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingInformation/AddressForm/__tests__/guestForm.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/plugins/__tests__/UpwardIncludePlugin.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/__tests__/wrap-esm-loader.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/__tests__/orderHistoryPage.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceAdjustments/CouponCode/__tests__/couponCode.spec.js
  • packages/pagebuilder/lib/ContentTypes/ButtonItem/__tests__/buttonItem.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceAdjustments/ShippingMethods/__tests__/shippingForm.spec.js
  • packages/peregrine/lib/targets/__tests__/HookInterceptorSet.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingMethod/__tests__/shippingMethod.spec.js
  • packages/venia-ui/lib/components/AddressBookPage/__tests__/addressBookPage.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/targetables/BabelModifyJSXPlugin/__tests__/Operation.spec.js
  • packages/venia-ui/lib/components/Dialog/__tests__/dialog.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingInformation/AddressForm/__tests__/customerForm.spec.js
  • packages/venia-ui/lib/components/CartPage/GiftCards/__tests__/giftCards.spec.js
  • packages/venia-ui/lib/components/Wishlist/AddToListButton/__tests__/addToListButton.ee.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/AddressBook/__tests__/addressBook.spec.js
  • packages/venia-ui/lib/components/MyAccount/ResetPassword/__tests__/resetPassword.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/PaymentInformation/__tests__/braintreeSummary.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/overview.spec.js
  • packages/venia-ui/lib/components/CommunicationsPage/__tests__/communicationsPage.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/addressForm.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceAdjustments/ShippingMethods/__tests__/shippingMethods.spec.js
  • packages/venia-ui/lib/components/CartPage/ProductListing/EditModal/__tests__/productForm.spec.js
  • packages/venia-ui/lib/targets/__tests__/makeRoutesTarget.spec.js
  • packages/venia-ui/lib/components/Wishlist/AddToListButton/__tests__/addToListButton.ce.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingMethod/__tests__/updateModal.spec.js
  • packages/venia-ui/lib/RootComponents/Category/__tests__/category.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/OrderConfirmationPage/__tests__/createAccount.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/shippingform.spec.js
  • packages/venia-ui/lib/components/CreateAccount/__tests__/createAccount.spec.js
  • packages/venia-ui/lib/components/AddressBookPage/__tests__/addressCard.spec.js
  • packages/venia-ui/lib/components/Wishlist/WishlistDialog/CreateWishlistForm/__tests__/createWishlistForm.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingInformation/__tests__/shippingInformation.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/GuestSignIn/__tests__/guestSignIn.spec.js
  • packages/venia-ui/lib/components/MiniCart/__tests__/miniCart.spec.js
  • packages/venia-ui/lib/components/AddToCartDialog/__tests__/addToCartDialog.spec.js
  • packages/venia-ui/lib/components/Password/__tests__/password.spec.js
  • packages/venia-ui/lib/components/SavedPaymentsPage/__tests__/creditCard.spec.js
  • packages/venia-ui/lib/components/CartPage/GiftCards/__tests__/giftCard.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/OrderDetails/__tests__/item.spec.js
  • packages/venia-ui/lib/targets/__tests__/CategoryListProductAttributes.spec.js
  • packages/venia-ui/lib/components/Gallery/__tests__/addToCartButton.spec.js
  • packages/venia-ui/lib/components/LegacyMiniCart/__tests__/section.spec.js
  • packages/venia-ui/lib/components/ForgotPassword/ForgotPasswordForm/__tests__/forgotPasswordForm.spec.js
  • packages/venia-ui/lib/components/AccountInformationPage/__tests__/editModal.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingMethod/__tests__/completedView.spec.js
  • packages/venia-ui/lib/components/AccountInformationPage/__tests__/editForm.spec.js
  • packages/venia-ui/lib/components/Checkout/Receipt/__tests__/receipt.spec.js
  • packages/pagebuilder/lib/ContentTypes/Banner/__tests__/banner.shimmer.spec.js
  • packages/pagebuilder/lib/__tests__/pagebuilder-targets.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/checkoutButton.spec.js
  • packages/venia-ui/lib/components/ProductSort/__tests__/productSort.spec.js
  • packages/pwa-buildpack/lib/__tests__/index.spec.js
Messages
:book: Associated JIRA tickets: [PWA-3216](https://jira.corp.magento.com/browse/PWA-3216).
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book: Access a deployed version of this PR [here](https://pr-4218.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: unitTests

ERROR ON TASK: scaffoldingSucceeds


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by :no_entry_sign: dangerJS against f5e759ce8976ab26a6c40b8f22b6e3661e127771