Closed RaghavendraTirumalasetti closed 7 months ago
Fails | |
---|---|
:no_entry_sign: | `node` failed. |
:no_entry_sign: | The following file(s) did not pass **ESLint**. Execute `yarn run lint` locally for more details ``` packages/peregrine/lib/talons/SignIn/useSignIn.js ``` |
:no_entry_sign: | The following file(s) were not formatted with **prettier**. Make sure to execute `yarn run prettier` locally prior to committing. ``` packages/peregrine/lib/talons/SignIn/__tests__/useSignIn.spec.js ``` |
Messages | |
---|---|
:book: | Associated JIRA tickets: [PWA-3230](https://jira.corp.magento.com/browse/PWA-3230). |
:book: | DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed). |
:book: | Access a deployed version of this PR [here](https://pr-4222.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete. |
ERROR ON TASK: prettierCheck
ERROR ON TASK: eslintCheck
Error: Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json
Generated by :no_entry_sign: dangerJS against 49897763b9ea7e6e47caac6fd09e1f7e72b2d1dd
Description
Login no longer works following 13.3.0. This is also visible on venia.magento.com
Related Issue
Closes #PWA-3230.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist