search

magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.06k stars 682 forks source link

PWA-3178::Order statuses are decoupled from the back-end #4229

Closed glo82145 closed 5 months ago

glo82145 commented 7 months ago

Description

A refunded order will show a wrong status. Custom order statuses are not shown.

To reproduce

Steps to reproduce the behavior: Refund an order in the admin. Create a custom order status and assign it to an order.

navigate to /order-history notice PWA-Studio's own take on order statuses Expected behavior

The frontend should accurately show the status of the order.

Related Issue

Closes #PWA-3178

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

pwa-studio-bot commented 7 months ago
Messages
:book: Associated JIRA tickets: [PWA-3178](https://jira.corp.magento.com/browse/PWA-3178).
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book: Access a deployed version of this PR [here](https://pr-4229.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by :no_entry_sign: dangerJS against ab4558b210e1c91b634c15b13efc1819e80b7856

fooman commented 7 months ago

In my opinion the solution should use the order state https://github.com/magento/magento2-pwa/blob/main/SalesGraphQlAux/etc/schema.graphqls#L5 instead of doing any derived calculations.

Also note that "Delivered" will be inacurrate until such time that the delivery has arrived at the customer's address. The complete status will automatically get applied once all items in an order have been marked invoice and shipped. Delivered to most people would indicate they have the item in their physical posession.

fooman commented 7 months ago

Just linking the original issue report here as well https://github.com/magento/pwa-studio/issues/3716