search

magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.06k stars 682 forks source link

PWA-3154:GraphQL cacheable requests always have Authorization Bearer … #4236

Closed glo11372 closed 6 months ago

glo11372 commented 6 months ago

Description

GraphQL cacheable requests always have Authorization Bearer header

Step to Create 1- sign up.in Venia.magento.com or any PWA store 2- login 3- check network tab on any page and search for GraphQL requests which should be cached such as CMSPages 4- check the request header you will not find Authorization Bearer header 5- Varnish will cache that request's response.

Related Issue

Closes # PWA-3154

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

pwa-studio-bot commented 6 months ago
Messages
:book: Associated JIRA tickets: [PWA-3154](https://jira.corp.magento.com/browse/PWA-3154).
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book: Access a deployed version of this PR [here](https://pr-4236.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by :no_entry_sign: dangerJS against 02ae675a7068b3cc02d22531d46c0bba02b46e6f

glo11372 commented 6 months ago

run lighthouse-desktop

pwa-test-bot[bot] commented 6 months ago

Successfully started codebuild job for lighthouse-desktop

glo11372 commented 6 months ago

run lighthouse-mobile

pwa-test-bot[bot] commented 6 months ago

Successfully started codebuild job for lighthouse-mobile

pwa-studio-bot commented 6 months ago
Fails
:no_entry_sign: `node` failed.

Log

``` Error: Error: Cannot find module './.lighthouseci/assertion-results.json' Require stack: - dangerfile.lighthouse.js - /usr/local/share/.config/yarn/global/node_modules/danger/distribution/runner/runners/inline.js - /usr/local/share/.config/yarn/global/node_modules/danger/distribution/commands/danger-runner.js ``` ERROR ON TASK: lighthouseTests ``` Error: Danger had errors running. See message(s) above for more details. danger-results://tmp/danger-results-6d468a14.json ```

Generated by :no_entry_sign: dangerJS against 02ae675a7068b3cc02d22531d46c0bba02b46e6f

pwa-studio-bot commented 6 months ago
Fails
:no_entry_sign: `node` failed.

Log

``` Error: Error: Cannot find module './.lighthouseci/assertion-results.json' Require stack: - dangerfile.lighthouse.js - /usr/local/share/.config/yarn/global/node_modules/danger/distribution/runner/runners/inline.js - /usr/local/share/.config/yarn/global/node_modules/danger/distribution/commands/danger-runner.js ``` ERROR ON TASK: lighthouseTests ``` Error: Danger had errors running. See message(s) above for more details. danger-results://tmp/danger-results-0260cf9a.json ```

Generated by :no_entry_sign: dangerJS against 34b2d4403400aac14e905d78a86375c14fbd4b2d

glo11372 commented 6 months ago

run lighthouse-desktop

pwa-test-bot[bot] commented 6 months ago

Successfully started codebuild job for lighthouse-desktop

glo11372 commented 6 months ago

run lighthouse-desktop

pwa-test-bot[bot] commented 6 months ago

Successfully started codebuild job for lighthouse-desktop