Closed glo11372 closed 4 months ago
Messages | |
---|---|
:book: | Associated JIRA tickets: [PWA-3154](https://jira.corp.magento.com/browse/PWA-3154). |
:book: | DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed). |
:book: | Access a deployed version of this PR [here](https://pr-4237.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete. |
Generated by :no_entry_sign: dangerJS against c3c3a64bceb59dd99109c6dd34b5eb4cede3b1e5
Fails | |
---|---|
:no_entry_sign: | `node` failed. |
Generated by :no_entry_sign: dangerJS against e2e138ec5c8462d606d61473686de3f0dde5ddfd
Fails | |
---|---|
:no_entry_sign: | `node` failed. |
Generated by :no_entry_sign: dangerJS against e2e138ec5c8462d606d61473686de3f0dde5ddfd
Fails | |
---|---|
:no_entry_sign: | `node` failed. |
:no_entry_sign: |
Cypress tests in the following files did _not_ pass 😔. All tests must pass before this PR can be merged
|
ERROR ON TASK: cypressTests
Error: Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json
Generated by :no_entry_sign: dangerJS against c3c3a64bceb59dd99109c6dd34b5eb4cede3b1e5
Fails | |
---|---|
:no_entry_sign: | `node` failed. |
:no_entry_sign: |
Cypress tests in the following files did _not_ pass 😔. All tests must pass before this PR can be merged
|
ERROR ON TASK: cypressTests
Error: Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json
Generated by :no_entry_sign: dangerJS against c3c3a64bceb59dd99109c6dd34b5eb4cede3b1e5
Description
GraphQL cacheable requests always have "Authorization Bearer" header Steps to test the behaviour :
1- sign up.in Venia.magento.com or any PWA store 2- login 3- check network tab on any page and search for GraphQL requests which should be cached such as CMSPages 4- check the request header you will not find Authorization Bearer header exist 5- Varnish will cache that request's response.
Related Issue
Closes #https://jira.corp.adobe.com/browse/PWA-3154
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist