Open martinyeboyebo opened 3 months ago
Fails | |
---|---|
:no_entry_sign: | `node` failed. |
:no_entry_sign: | A version label is required. A maintainer must add one. |
:no_entry_sign: |
Unit tests in the following files did _not_ pass 😔. All tests must pass before this PR can be merged
|
:no_entry_sign: |
No linked issue found. Please link a relevant open issue by adding the text "closes # |
Messages | |
---|---|
:book: | DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed). |
:book: | Access a deployed version of this PR [here](https://pr-4257.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete. |
ERROR ON TASK: unitTests
Error: Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json
Generated by :no_entry_sign: dangerJS against 39c864b423c2cb36e83c2501092a99ecfbc1c9c3
Description
Fix Peregrine Talon by category from menu called useMegaMenuItem by replacing the attribute category_id by category_uid
Related Issue
The categories are not marked as active since their identifier is uid and not id. I correct the identifier so that the categories are marked correctly when you visit one of them.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist