Closed glo11372 closed 1 month ago
Fails | |
---|---|
:no_entry_sign: | `node` failed. |
:no_entry_sign: | GraphQL queries did not pass. Make sure to execute `yarn run validate-queries` locally prior to committing. |
Messages | |
---|---|
:book: | DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed). |
:book: | Access a deployed version of this PR [here](https://pr-4260.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete. |
ERROR ON TASK: validateQueries
Error: Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json
Generated by :no_entry_sign: dangerJS against facd23dc97ef3f9087d8b5d92e5a76a2b7c08e47
Hi @glo11372 the mutation generateCustomerToken
didn't return cookie_lifetime
so far, why we don't use Customer Token Lifetime in (stores->configuration->services->OAuth->Access Token Expiration>Customer Token Lifetime (hours) ) ?
Hi @glo11372 the mutation
generateCustomerToken
didn't returncookie_lifetime
so far, why we don't use Customer Token Lifetime in (stores->configuration->services->OAuth->Access Token Expiration>Customer Token Lifetime (hours) ) ?
Hi @huykon
Description
1.Inside admin panel set any value of Cookie Lifetime (stores->configuration->general->web->DefaultCookies setting>Cookie Lifetime)
Related Issue
Closes #4230
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
1.Try to change admin panel cookies lifetime value and test on frontend 2.If the value is empty it will by default use 3600
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist