Closed glo85315 closed 2 months ago
Fails | |
---|---|
:no_entry_sign: | `node` failed. |
:no_entry_sign: |
Unit tests in the following files did _not_ pass 😔. All tests must pass before this PR can be merged
|
Messages | |
---|---|
:book: | Associated JIRA tickets: [PWA-3260](https://jira.corp.magento.com/browse/PWA-3260). |
:book: | DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed). |
:book: | Access a deployed version of this PR [here](https://pr-4264.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete. |
ERROR ON TASK: unitTests
Error: Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json
Generated by :no_entry_sign: dangerJS against 3027788a1ee77d5fd4a5e92a44f26df9760af660
Description
Login to Magento Admin Create or Edit block, add html element and add any javascript in that Add that block in footer or somewhere in page Goto PWA Venia frontend and check, javascript is loading but it is not executable.
Related Issue
Closes #https://jira.corp.adobe.com/browse/PWA-3260
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Login to Magento Admin Create or Edit block, add html element and add any javascript in that Add that block in footer or somewhere in page Goto PWA Venia frontend and check, javascript is loading .
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist