search

magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.06k stars 683 forks source link

Pwa 3216 v1 #4274

Closed glo82145 closed 2 months ago

glo82145 commented 2 months ago

Description

TODO: Describe your changes in detail here.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

pwa-studio-bot commented 2 months ago
Fails
:no_entry_sign: `node` failed.
:no_entry_sign: A version label is required. A maintainer must add one.
:no_entry_sign: Unable to build scaffolded project. ``` yarn build ``` within a scaffolded project directory failed. Learn more about Scaffolding at https://magento.github.io/pwa-studio/pwa-buildpack/scaffolding/.
:no_entry_sign: Unit tests in the following files did _not_ pass 😔. All tests must pass before this PR can be merged
  • packages/pagebuilder/lib/ContentTypes/Banner/__tests__/banner.spec.js
  • packages/peregrine/lib/targets/__tests__/peregrine-targets.spec.js
  • packages/venia-ui/lib/components/ProductFullDetail/__tests__/productFullDetail.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/__tests__/checkoutPage.spec.js
  • packages/pwa-buildpack/lib/Utilities/__tests__/configureHost.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/OrderDetails/__tests__/orderDetails.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/targetables/__tests__/TargetableReactComponent.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/plugins/__tests__/RootComponentsPlugin.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/plugins/__tests__/LocalizationPlugin.spec.js
  • packages/venia-ui/lib/components/ProductImageCarousel/__tests__/carousel.spec.js
  • packages/venia-ui/lib/targets/__tests__/venia-ui-targets.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/paymentsForm.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceSummary/__tests__/priceSummary.spec.js
  • packages/venia-ui/lib/components/CartPage/ProductListing/__tests__/product.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingInformation/AddressForm/__tests__/guestForm.spec.js
  • packages/pagebuilder/lib/ContentTypes/ButtonItem/__tests__/buttonItem.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/__tests__/orderHistoryPage.spec.js
  • packages/pwa-buildpack/lib/WebpackTools/plugins/__tests__/UpwardIncludePlugin.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceAdjustments/CouponCode/__tests__/couponCode.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceAdjustments/ShippingMethods/__tests__/shippingForm.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingMethod/__tests__/shippingMethod.spec.js
  • packages/venia-ui/lib/components/AddressBookPage/__tests__/addressBookPage.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingInformation/AddressForm/__tests__/customerForm.spec.js
  • packages/venia-ui/lib/components/Dialog/__tests__/dialog.spec.js
  • packages/venia-ui/lib/components/CartPage/GiftCards/__tests__/giftCards.spec.js
  • packages/venia-ui/lib/components/Wishlist/AddToListButton/__tests__/addToListButton.ee.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/AddressBook/__tests__/addressBook.spec.js
  • packages/venia-ui/lib/components/MyAccount/ResetPassword/__tests__/resetPassword.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/PaymentInformation/__tests__/braintreeSummary.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/overview.spec.js
  • packages/venia-ui/lib/components/CommunicationsPage/__tests__/communicationsPage.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/addressForm.spec.js
  • packages/venia-ui/lib/components/CartPage/PriceAdjustments/ShippingMethods/__tests__/shippingMethods.spec.js
  • packages/venia-ui/lib/components/CartPage/ProductListing/EditModal/__tests__/productForm.spec.js
  • packages/venia-ui/lib/components/Wishlist/AddToListButton/__tests__/addToListButton.ce.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingMethod/__tests__/updateModal.spec.js
  • packages/venia-ui/lib/RootComponents/Category/__tests__/category.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/OrderConfirmationPage/__tests__/createAccount.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/shippingform.spec.js
  • packages/venia-ui/lib/components/CreateAccount/__tests__/createAccount.spec.js
  • packages/venia-ui/lib/components/AddressBookPage/__tests__/addressCard.spec.js
  • packages/venia-ui/lib/components/Wishlist/WishlistDialog/CreateWishlistForm/__tests__/createWishlistForm.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingInformation/__tests__/shippingInformation.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/GuestSignIn/__tests__/guestSignIn.spec.js
  • packages/venia-ui/lib/components/MiniCart/__tests__/miniCart.spec.js
  • packages/venia-ui/lib/components/AddToCartDialog/__tests__/addToCartDialog.spec.js
  • packages/venia-ui/lib/components/Password/__tests__/password.spec.js
  • packages/venia-ui/lib/components/SavedPaymentsPage/__tests__/creditCard.spec.js
  • packages/venia-ui/lib/components/CartPage/GiftCards/__tests__/giftCard.spec.js
  • packages/venia-ui/lib/components/OrderHistoryPage/OrderDetails/__tests__/item.spec.js
  • packages/venia-ui/lib/components/Gallery/__tests__/addToCartButton.spec.js
  • packages/venia-ui/lib/components/LegacyMiniCart/__tests__/section.spec.js
  • packages/venia-ui/lib/components/ForgotPassword/ForgotPasswordForm/__tests__/forgotPasswordForm.spec.js
  • packages/venia-ui/lib/components/CheckoutPage/ShippingMethod/__tests__/completedView.spec.js
  • packages/venia-ui/lib/components/AccountInformationPage/__tests__/editModal.spec.js
  • packages/venia-ui/lib/components/AccountInformationPage/__tests__/editForm.spec.js
  • packages/venia-ui/lib/components/Checkout/Receipt/__tests__/receipt.spec.js
  • packages/pagebuilder/lib/ContentTypes/Banner/__tests__/banner.shimmer.spec.js
  • packages/venia-ui/lib/components/Checkout/__tests__/checkoutButton.spec.js
  • packages/venia-ui/lib/components/ProductSort/__tests__/productSort.spec.js
:no_entry_sign: No linked issue found. Please link a relevant open issue by adding the text "closes #" or "closes JIRA-" in your PR.
:no_entry_sign: Missing information in PR. Please fill out the "Description" section.
Warnings
:warning: Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book: Access a deployed version of this PR [here](https://pr-4274.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: unitTests

ERROR ON TASK: scaffoldingSucceeds


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by :no_entry_sign: dangerJS against 6bcbfaa34caebc43493f9205ee831c0c8df2210b