Closed glo82145 closed 2 months ago
Fails | |
---|---|
:no_entry_sign: | `node` failed. |
:no_entry_sign: | A version label is required. A maintainer must add one. |
:no_entry_sign: | Unable to build scaffolded project. ``` yarn build ``` within a scaffolded project directory failed. Learn more about Scaffolding at https://magento.github.io/pwa-studio/pwa-buildpack/scaffolding/. |
:no_entry_sign: |
No linked issue found. Please link a relevant open issue by adding the text "closes # |
:no_entry_sign: | Missing information in PR. Please fill out the "Description" section. |
:no_entry_sign: |
Unit tests in the following files did _not_ pass 😔. All tests must pass before this PR can be merged
|
:no_entry_sign: | The following file(s) did not pass **ESLint**. Execute `yarn run lint` locally for more details ``` packages/pwa-buildpack/lib/Utilities/__tests__/createProject.spec.js ``` |
:no_entry_sign: | The following file(s) were not formatted with **prettier**. Make sure to execute `yarn run prettier` locally prior to committing. ``` packages/peregrine/lib/targets/__tests__/HookInterceptorSet.spec.js packages/peregrine/lib/targets/__tests__/peregrine-targets.spec.js packages/pwa-buildpack/lib/Utilities/__tests__/configureHost.spec.js packages/pwa-buildpack/lib/WebpackTools/plugins/__tests__/LocalizationPlugin.spec.js packages/pwa-buildpack/lib/WebpackTools/plugins/__tests__/RootComponentsPlugin.spec.js packages/venia-concept/_buildpack/__tests__/create.spec.js packages/venia-ui/lib/targets/__tests__/venia-ui-targets.spec.js ``` |
Warnings | |
---|---|
:warning: | Found the word "TODO" in the PR description. Just letting you know incase you forgot :) |
Messages | |
---|---|
:book: | DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed). |
:book: | Access a deployed version of this PR [here](https://pr-4275.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete. |
ERROR ON TASK: prettierCheck
ERROR ON TASK: eslintCheck
ERROR ON TASK: unitTests
ERROR ON TASK: scaffoldingSucceeds
Error: Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json
If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.
Generated by :no_entry_sign: dangerJS against b2862c4313cc5bd0db33516d9097e6fd66ff2aa8
this pr re-introduces package-lock.json again - please see https://github.com/magento/pwa-studio/issues/4203 I would suggest adding this to your .gitignore file
run pr-test
Successfully started codebuild job for pr-test
run pr-test
Successfully started codebuild job for pr-test
run pr-test
Successfully started codebuild job for pr-test
Description
TODO: Describe your changes in detail here.
Related Issue
Closes #ISSUE_NUMBER.
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist