Open glo85315 opened 1 month ago
Fails | |
---|---|
:no_entry_sign: | `node` failed. |
:no_entry_sign: | A version label is required. A maintainer must add one. |
:no_entry_sign: | Unable to build scaffolded project. ``` yarn build ``` within a scaffolded project directory failed. Learn more about Scaffolding at https://magento.github.io/pwa-studio/pwa-buildpack/scaffolding/. |
:no_entry_sign: |
Unit tests in the following files did _not_ pass 😔. All tests must pass before this PR can be merged
|
:no_entry_sign: | The following file(s) did not pass **ESLint**. Execute `yarn run lint` locally for more details ``` packages/venia-ui/lib/components/App/localeProvider.js ``` |
Messages | |
---|---|
:book: | Associated JIRA tickets: [PWA-3294](https://jira.corp.magento.com/browse/PWA-3294). |
:book: | DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed). |
:book: | Access a deployed version of this PR [here](https://pr-4282.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete. |
ERROR ON TASK: eslintCheck
ERROR ON TASK: unitTests
ERROR ON TASK: scaffoldingSucceeds
Error: Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json
Generated by :no_entry_sign: dangerJS against a92b95b1272001349b699ccdb430b7b340e229c1
Description
PLP should displayed on all store view.
Related Issue
https://jira.corp.adobe.com/browse/PWA-3294
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist