magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.06k stars 682 forks source link

Cannot filter on options with a "," #4304

Open vacla opened 1 month ago

vacla commented 1 month ago

Describe the bug

After selecting a category with a "," on the category page, no results are found or wrong results shown. This is very likey due to the delimiter being a "," here: https://github.com/magento/pwa-studio/blob/develop/packages/peregrine/lib/talons/FilterModal/helpers.js#L1

To reproduce

Steps to reproduce the behavior:

  1. Go to category page
  2. Click on filter with a ","
  3. No results found or not showing correct results

Expected behavior

Show results of that category

Debug Report

` ℹ Inspecting Dependencies Found 9 @magento dependencies in yarn.lock @magento/pwa-buildpack @ 11.4.3 @adobe/apollo-link-mutation-queue @ 1.0.2 @magento/babel-preset-peregrine @ 1.2.3 @magento/eslint-config @ 1.5.3 @magento/pagebuilder @ 8.2.1 @magento/peregrine @ 13.2.1 @magento/pwa-theme-venia @ 1.4.0 @magento/venia-adobe-data-layer @ 1.0.0 @magento/venia-ui @ 10.3.0

ℹ Inspecting Magento Backend Not using sample backend. Backend is UP!

ℹ Inspecting System OS: #39-Ubuntu SMP PREEMPT_DYNAMIC Fri Jul 5 21:49:14 UTC 2024 Node Version: v16.20.2 NPM Version: 8.19.4

`

Please complete the following device information:

Please let us know what packages this bug is in regards to:

m2-assistant[bot] commented 1 month ago

Hi @vacla. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information. Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.