magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.07k stars 684 forks source link

inline_script: inline script code to excute in PWA APP #4306

Closed glo85315 closed 3 months ago

glo85315 commented 3 months ago

Description

TODO: Describe your changes in detail here.

Related Issue

Closes #ISSUE_NUMBER.

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

pwa-studio-bot commented 3 months ago
Fails
:no_entry_sign: `node` failed.
:no_entry_sign: A version label is required. A maintainer must add one.
:no_entry_sign: No linked issue found. Please link a relevant open issue by adding the text "closes #" or "closes JIRA-" in your PR.
:no_entry_sign: Missing information in PR. Please fill out the "Description" section.
:no_entry_sign: Unit tests in the following files did _not_ pass 😔. All tests must pass before this PR can be merged
  • packages/peregrine/lib/targets/__tests__/peregrine-targets.spec.js
  • packages/pagebuilder/lib/ContentTypes/Html/__tests__/html.spec.js
:no_entry_sign: The following file(s) did not pass **ESLint**. Execute `yarn run lint` locally for more details ``` packages/pagebuilder/lib/ContentTypes/Html/html.js packages/peregrine/lib/hooks/useExecuteScripts.js packages/peregrine/lib/index.js ```
:no_entry_sign: The following file(s) were not formatted with **prettier**. Make sure to execute `yarn run prettier` locally prior to committing. ``` packages/pagebuilder/lib/ContentTypes/Html/html.js packages/peregrine/lib/hooks/useExecuteScripts.js packages/peregrine/lib/index.js packages/peregrine/lib/util/nonceGenerator.js ```
Warnings
:warning: Found the word "TODO" in the PR description. Just letting you know incase you forgot :)
Messages
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book: Access a deployed version of this PR [here](https://pr-4306.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: prettierCheck

ERROR ON TASK: eslintCheck

ERROR ON TASK: unitTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by :no_entry_sign: dangerJS against 4fa003668722c8dc5caf057cd5a96f6992d58804