search

magento / pwa-studio

šŸ› Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.07k stars 684 forks source link

It seems that the poster for the video does not update when the video ID is changed. This could lead to confusion for users. #4313

Open arvind-netzwelt opened 3 months ago

arvind-netzwelt commented 3 months ago

Describe the bug

A clear and concise description of what the bug is.

To reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior I have used Venia PWA with Magento 2. I have used React-player to show a YouTube video. If I change the YouTube video in Magento, the poster of the video does not change. However, in GraphQL, the ID of the video is changed. How can this be handled?

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Possible solutions

Add any ideas about possible solutions to the problem here.

Debug Report

Paste the output of yarn build:report, and any other context about the problem, here.

Please complete the following device information:

Please let us know what packages this bug is in regards to:

m2-assistant[bot] commented 3 months ago

Hi @arvind-netzwelt. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information. Add a comment to assign the issue: @magento I am working on this

Join Magento Community Engineering Slack and ask your questions in #github channel.

glo82145 commented 2 months ago

@adobe export issue to JIRA project PWA as Bug

github-jira-sync-bot commented 2 months ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/PWA-3357 is successfully created for this GitHub issue.

del15881 commented 1 month ago

@arvind-netzwelt hi, we'd like more information on this issue. We tried to add a video to the PWA venia-storefront using Magento Admin pagebuilder. We then replaced the first video URL with a new one and refreshed the cache from Magento admin and then checked the PWA-frontend and the Banner updated correctly for us.

Do you have any specific steps to recreate the issue ?

arvind-netzwelt commented 1 month ago

I have added the code like this, youtubeCaption changed on Graphql but not changed on frontend. after clear the browser cookies its working fine

<ReactPlayer key={${youTubeUrl}-${youtubeCaption}} width="100%" height={isDesktop ? '400px' : '200px'} url={youTubeUrl} playing={playing} className={classes.modalVideo} controls={false} light={youtubeCaption || true} playIcon={ <PlayPauseButton playing={playing} handlePlayPause={handlePlayPause} /> } />

del15881 commented 1 month ago

Hey @arvind-netzwelt , Thank you for your response. As part of our current process, we are unable to accommodate requests for custom code changes directly. However, we welcome and encourage contributions from community members who are interested in supporting code enhancements.