Pwa 3279 - Githubissues

magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.

Open Software License 3.0

1.06k stars 682 forks source link

Description

1.On unmount, useScrollLock to set the scroll lock to false, in cases where the modal doesn't have time to have it's isOpen updated.

Related Issue

Closes #4238

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

I have added tests to cover my changes, if necessary.
I have added translations for new strings, if necessary.
I have updated the documentation accordingly, if necessary.

	Fails
:no_entry_sign:	A version label is required. A maintainer must add one.

Fails

:no_entry_sign:

A version label is required. A maintainer must add one.

	Messages
:book:	DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book:	Access a deployed version of this PR [here](https://pr-4315.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Messages

:book:

DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).