magento / pwa-studio

🛠Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.07k stars 683 forks source link

[bug]: No css variable #4317

Open JeremyKomarov opened 2 months ago

JeremyKomarov commented 2 months ago

Describe the bug When build something in page builder Row -> Tabs

in venia when you switch between tabs then the unselected tabs are are still displyed

To reproduce

Steps to reproduce the behavior:

i saw that in @magento->pagebuilder->lib->ContentTypes->tabs->tabs.module.css there is this css: .panel { min-height: inherit; composes: !empty_hidden from global; }

i didnt find this css anyhwere "empty_hidden" and why its !empty_hidden ? all other css are using just "empty_hidden"

and still couldnt find this css "empty_hidden" anywhere

  1. Go to 'Admin -> content -> pages -> create page builder' with rows -> tabs->

Expected behavior when you switch between tabs then the other tabs will be none displyed

m2-assistant[bot] commented 2 months ago

Hi @JeremyKomarov. Thank you for your report. To speed up processing of this issue, make sure that you provided sufficient information. Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

glo82145 commented 1 month ago

@adobe export issue to JIRA project PWA as Bug

github-jira-sync-bot commented 1 month ago

:white_check_mark: Jira issue https://jira.corp.adobe.com/browse/PWA-3356 is successfully created for this GitHub issue.