magento / pwa-studio

šŸ› Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.07k stars 683 forks source link

Fixed pagebuilder tab toggle issue #4327

Closed del22123 closed 1 month ago

del22123 commented 1 month ago

Description

This PR contains the fix for CSS issues in page builder tab content toggle.

Closes #PWA-3356 https://jira.corp.adobe.com/browse/PWA-3356

Acceptance

Verification Stakeholders

Specification

Verification Steps

Step 1: Create a static content (Either a page or static block) in Magento admin panel Step 2: Use page builder to edit the content, drag and drop "Tab" inside a row (Drag and drop the "Row" into the content area if it's not there already) Step 3: Create multiple tabs to have toggle in storefront Step 4: Save the content and check the tab(s) in storefront (Configure the static block/page appropriately so that the content will be visible in storefront)

Current result: Empty space will be visible on each tab switch

Fix result: The tab content toggle will work and there won't be any empty space/in-active tab content displayed.

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

pwa-studio-bot commented 1 month ago
Fails
:no_entry_sign: A version label is required. A maintainer must add one.
Messages
:book: Associated JIRA tickets: [PWA-3356](https://jira.corp.magento.com/browse/PWA-3356).
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book: Access a deployed version of this PR [here](https://pr-4327.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by :no_entry_sign: dangerJS against 47ce6b30d0b07ca45632616ccc9fa000324685a8