search

magento / pwa-studio

šŸ› Development tools to build, optimize and deploy Progressive Web Applications for Magento 2.
https://developer.adobe.com/commerce/pwa-studio/
Open Software License 3.0
1.07k stars 683 forks source link

PWA-3318::Prex compatibility #4349

Open glo82145 opened 2 weeks ago

glo82145 commented 2 weeks ago

Description

We need to make sure all OOTB PREX function should work when installed along with PWA-Studio. To achieve same we need to check which all scenerios are working or not and once it all possible cases check done, we need to incorportae required missing functionality including frontend and Backend data analytics in respect of PWA-Studio Compatibility Scope.

https://developer.adobe.com/commerce/pwa-studio/integrations/product-recommendations/ https://experienceleague.adobe.com/en/docs/commerce-merchant-services/product-recommendations/getting-started/headless https://experienceleague.adobe.com/en/docs/commerce-merchant-services/product-recommendations/getting-started/install-configure

Preconditions

None

Acceptance Criteria PREX Extenstion along with BackendMetapackages should be compatible to use with magento All PREX Front End Metapackages should be integrated in PWA-studio Repo in extenstion folder to directly install locally

Related Issue

Closes #PWA-3318

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

pwa-studio-bot commented 2 weeks ago
Fails
:no_entry_sign: `node` failed.
:no_entry_sign: The following file(s) did not pass **ESLint**. Execute `yarn run lint` locally for more details ``` packages/extensions/venia-product-recommendations/lib/components/VeniaProductRecommendations/VeniaProductRecommendations.js packages/extensions/venia-product-recommendations/lib/hooks/useObserver.js packages/extensions/venia-product-recommendations/lib/hooks/useRecsTrackingProps.js packages/extensions/venia-product-recommendations/lib/hooks/useSyncMSEToLocalStorage.js packages/extensions/venia-product-recommendations/lib/queries/getCart.gql.js packages/extensions/venia-product-recommendations/package.json ```
:no_entry_sign: The following file(s) were not formatted with **prettier**. Make sure to execute `yarn run prettier` locally prior to committing. ``` packages/extensions/venia-product-recommendations/babel.config.js packages/extensions/venia-product-recommendations/jest.config.js packages/extensions/venia-product-recommendations/lib/components/Gallery/gallery.css packages/extensions/venia-product-recommendations/lib/components/Gallery/Gallery.js packages/extensions/venia-product-recommendations/lib/components/Gallery/item.css packages/extensions/venia-product-recommendations/lib/components/VeniaProductRecommendations/ProductRecommendations.css packages/extensions/venia-product-recommendations/lib/components/VeniaProductRecommendations/VeniaProductRecommendations.js packages/extensions/venia-product-recommendations/lib/hooks/useObserver.js packages/extensions/venia-product-recommendations/lib/hooks/useRecsData.js packages/extensions/venia-product-recommendations/lib/hooks/useRecsTrackingProps.js packages/extensions/venia-product-recommendations/lib/hooks/useSyncMSEToLocalStorage.js packages/extensions/venia-product-recommendations/lib/index.js packages/extensions/venia-product-recommendations/lib/queries/getCart.gql.js packages/extensions/venia-product-recommendations/lib/targets/intercept.js packages/extensions/venia-product-recommendations/lib/wrappers/wrapUseApp.js packages/extensions/venia-product-recommendations/lib/wrappers/wrapUseGalleryItem.js packages/extensions/venia-product-recommendations/test/mocks.js packages/peregrine/lib/talons/Gallery/isSupportedProductType.js packages/venia-ui/lib/components/Gallery/item.js ```
Messages
:book: Associated JIRA tickets: [PWA-3318](https://jira.corp.magento.com/browse/PWA-3318).
:book: DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
:book: Access a deployed version of this PR [here](https://pr-4349.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Log

ERROR ON TASK: prettierCheck

ERROR ON TASK: eslintCheck


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by :no_entry_sign: dangerJS against 0a3ab1fbb268b425c18cd036c62de750c9feb834