Open del22123 opened 1 week ago
Messages | |
---|---|
:book: | Associated JIRA tickets: [PWA-3381](https://jira.corp.magento.com/browse/PWA-3381). |
:book: | DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed). |
:book: | Access a deployed version of this PR [here](https://pr-4351.pwa-venia.com/). Make sure to wait for the "pwa-pull-request-deploy" job to complete. |
Generated by :no_entry_sign: dangerJS against 60aec353c8f334b32256161b77ac339d346a9cdc
run pr-deploy
Successfully started codebuild job for pr-deploy
Fails | |
---|---|
:no_entry_sign: | `node` failed. |
:no_entry_sign: |
Cypress tests in the following files did _not_ pass 😔. All tests must pass before this PR can be merged
|
ERROR ON TASK: cypressTests
Error: Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json
Generated by :no_entry_sign: dangerJS against 60aec353c8f334b32256161b77ac339d346a9cdc
Fails | |
---|---|
:no_entry_sign: | `node` failed. |
:no_entry_sign: |
Cypress tests in the following files did _not_ pass 😔. All tests must pass before this PR can be merged
|
ERROR ON TASK: cypressTests
Error: Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json
Generated by :no_entry_sign: dangerJS against 60aec353c8f334b32256161b77ac339d346a9cdc
Description
This PR contains the fix for handleTriggerClick function call error in customer login flow when require email confirmation is enabled and or wrong password is given.
Closes #PWA-3381 https://jira.corp.adobe.com/browse/PWA-3381
Acceptance
Verification Stakeholders
Specification
Verification Steps
Step 1: Enable customer email confirmation from Magento Admin panel -> Stores -> Customer -> Customer Configuration -> Create New Account Options -> Require Emails Confirmation -> Yes and save the config Step 2: In PWA store view add a product to cart and then go to Checkout page -> Sign In-> Create an account (or) Header -> Sign in -> Create an account Step 3: Enter all the necessary details for the new customer account (Email should not exist already in the website) Step 4: Click create an account button Step 5: Once the user is created try to login to the newly created account (This issue may happen even with existing account when wrong password is given while sign in)
Current result: No error is thrown and account will not login
Fix result: Existing generic error message will be shown (An error has occurred. Please check the input and try again)
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist